Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][State Compat] Fail state compat check if app hash is detectted #6455

Closed
p0mvn opened this issue Sep 20, 2023 · 2 comments
Closed

[CI][State Compat] Fail state compat check if app hash is detectted #6455

p0mvn opened this issue Sep 20, 2023 · 2 comments

Comments

@p0mvn
Copy link
Member

p0mvn commented Sep 20, 2023

Background

Currently, if an app hash is detected, we do not fail the CI and it keeps on running:
#6449

This leads to confusion and time wasted waiting for nothing (unless you check ofc)

Suggested Design

Still, for better feedback loop, we should detect an app hash and fail the CI if it occurs

Acceptance Criteria

  • fail state compact CI if app hash is detected
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Sep 20, 2023
@p0mvn p0mvn changed the title CI][State Compat] Fail state compat check if app hash is detectted [CI][State Compat] Fail state compat check if app hash is detectted Sep 20, 2023
@anhductn2001
Copy link
Contributor

I think it is difficult to detect the app hash. The best way currently in my mind is to set a timeout for this job. If you agree I will do it. @p0mvn

@ValarDragon
Copy link
Member

I believe this is solved?

@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to Done ✅ in Osmosis Chain Development Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants