Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(CL): swapstrategy package tests at low price level #6354

Open
Tracked by #5726
p0mvn opened this issue Sep 11, 2023 · 0 comments
Open
Tracked by #5726

test(CL): swapstrategy package tests at low price level #6354

p0mvn opened this issue Sep 11, 2023 · 0 comments
Labels
C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board T:tests

Comments

@p0mvn
Copy link
Member

p0mvn commented Sep 11, 2023

Background

Given the bug in #6351, it might be prudent to unit test our internal functions at a lower price level more extensively than it is right now.

Suggested Design

Review every function in the swapstrategy package. Where applicable, add a test case at a lower price level (near min tick bound). Try to reason about cases where rounding errors can be amplified

Acceptance Criteria

  • Reviewed each function
  • Tests around min spot price added
  • Reason about error amplification
@p0mvn p0mvn added T:tests C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board labels Sep 11, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board T:tests
Projects
Status: Needs Triage 🔍
Development

No branches or pull requests

1 participant