Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bank module's exported genesis validation fails after denom creation in tokenfactory module #6343

Closed
madrezaz opened this issue Sep 8, 2023 · 0 comments · Fixed by #6344
Closed

Comments

@madrezaz
Copy link
Contributor

madrezaz commented Sep 8, 2023

Background

In tokenfactory's createDenomAfterValidation function, a metadata is set for the denom that is being created with the following format:

denomMetaData := banktypes.Metadata{
	DenomUnits: []*banktypes.DenomUnit{{
		Denom:    denom,
		Exponent: 0,
	}},
	Base: denom,
}

in which the name, symbol and display fields are not set. In this case, bank module's exported genesis' validation will fail since it validates that the mentioned fields are not empty.

Suggested Design

The name, symbol and display fields of metadata should be set.

Acceptance Criteria

All existing and new tests should pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant