Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(CL): remove CalculatePriceToTickDecV1 function #6247

Closed
Tracked by #5726
p0mvn opened this issue Aug 30, 2023 · 0 comments
Closed
Tracked by #5726

refactor(CL): remove CalculatePriceToTickDecV1 function #6247

p0mvn opened this issue Aug 30, 2023 · 0 comments
Assignees
@p0mvn
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board

Comments

@p0mvn
Copy link
Member

p0mvn commented Aug 30, 2023 •
edited
Loading

Context

In #6246, it was proposed to keep the V1 function for the purposes of displaying 1:1 conversions with the new version via Go test.

Here, we will remove the Go test and the old version

A/C

  • Remove test
  • Remove CalculatePriceToTickDecV1
@p0mvn p0mvn mentioned this issue Aug 30, 2023
Open
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Aug 30, 2023
@p0mvn p0mvn added the F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board label Aug 30, 2023
@p0mvn p0mvn mentioned this issue Aug 31, 2023
Merged
6 tasks
@p0mvn p0mvn self-assigned this Aug 31, 2023
@p0mvn p0mvn closed this as completed Sep 1, 2023
@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to Done ✅ in Osmosis Chain Development Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p0mvn p0mvn

Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p0mvn