Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support concurrency for IAVL #5928

Closed
Tracked by #5191
mattverse opened this issue Jul 31, 2023 · 3 comments
Closed
Tracked by #5191

Support concurrency for IAVL #5928

mattverse opened this issue Jul 31, 2023 · 3 comments
Assignees
@mattverse

Comments

@mattverse
Copy link
Member

Background

Related issues are:

Previously, concurrency in IAVL were not supported due to issues mentioned above. Right now nodes would occasionally crash with racing conditions, even with concurrency option turned off.

Suggested Design

Use sync.Map for the map where race condition is happeninng.

cosmos/iavl#802 PR is up here, we need to decide how we want to apply this in v17 since it would time some time to get upstreamed.
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Jul 31, 2023
@mattverse mattverse mentioned this issue Jul 31, 2023
Closed
@mattverse mattverse self-assigned this Jul 31, 2023
@amanPradhan05
Copy link

Can I fix this issue?

@mattverse
Copy link
Member Author

@amanPradhan05 Thanks for asking! Unfortunately, we already have the fix ready in cosmos/iavl#802! I just have to create a PR pointing to main 🔥

@ValarDragon
Copy link
Member

I believe this should be fixed now?

@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to Done ✅ in Osmosis Chain Development Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattverse mattverse

Labels
None yet
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ValarDragon @mattverse @amanPradhan05