Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: uninitialize ticks when not referenced anymore #5867

Closed
Tracked by #5191
p0mvn opened this issue Jul 18, 2023 · 0 comments · Fixed by #5883
Closed
Tracked by #5191

refactor: uninitialize ticks when not referenced anymore #5867

p0mvn opened this issue Jul 18, 2023 · 0 comments · Fixed by #5883
Assignees
@czarcas7ic
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board

Comments

@p0mvn
Copy link
Member

p0mvn commented Jul 18, 2023

Background

Currently, we do not have logic for uninitializing ticks. We should implement it to avoid polluting the state with obsolete tick data

Suggested Design

Ticks are auto-unitialized once liquidity gross becomes zero.

This can be checked in WithdrawPosition

Acceptance Criteria

  • functionality implemented
  • tested
  • reason about how to deal with obsolete ticks already present on mainnet
@p0mvn p0mvn added the F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board label Jul 18, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Jul 18, 2023
@p0mvn p0mvn mentioned this issue Jul 18, 2023
Closed
@czarcas7ic czarcas7ic moved this from Needs Triage 🔍 to Todo 🕒 in Osmosis Chain Development Jul 24, 2023
@czarcas7ic czarcas7ic self-assigned this Jul 24, 2023
@czarcas7ic czarcas7ic moved this from Todo 🕒 to In Progress🏃 in Osmosis Chain Development Jul 24, 2023
@czarcas7ic czarcas7ic mentioned this issue Jul 25, 2023
Merged
6 tasks
@czarcas7ic czarcas7ic moved this from In Progress🏃 to Needs PR Review in Osmosis Chain Development Jul 25, 2023
@github-project-automation github-project-automation bot moved this from Needs PR Review to Done ✅ in Osmosis Chain Development Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@czarcas7ic czarcas7ic

Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: uninitialize empty ticks osmosis-labs/osmosis
2 participants
@p0mvn @czarcas7ic