CL: investigate removing a hack in tick updates when stopping swap within a bucket

[p0mvn]

Background

#5526 added a hack that was breaking some swap tick iterator tests:

osmosis/x/concentrated-liquidity/swaps.go

Lines 375 to 388 in 398380e

	// TEMPORARY HACK: this is to fix tick rounding error where
	// the tick is off by 1 due to banker's rounding error in CalculatePriceToTick
	// TODO: if this is to remain in the codebase, consider abstracting this into a
	// method of swap strategy.
	isZeroForOne := getZeroForOne(tokenInMin.Denom, p.GetToken0())
	if isZeroForOne {
	if newTick <= swapState.tick {
	swapState.tick = newTick
	}
	} else {
	if newTick > swapState.tick {
	swapState.tick = newTick
	}
	}

Upon merging #5541, some of the branches stopped being hit by tests. Ref: https://github.com/osmosis-labs/osmosis/pull/5526/files#r1234321848

Suggested Design

After #5543 is merged, we should investigate removing the hack or ensuring that each branch is covered by a test and has an explanation

Acceptance Criteria

• hack is either removed or fully covered with tests
• add summary to [CL]: Create testing_strategy.md #5570