[CL][bug]: Can trigger panic/chain halt due to incorrect bound check

[AlpinYukseloglu]

Background

The bound check below is incorrect and allows for the case where curSqrtPrice = upperSqrtPrice to be routed into Liquidity1, triggering a division by zero. It is trivial to get any pool to this state, including ones that protorev/txfees swap against in beginblock, allowing this issue to be easily escalated to a chain halt.

osmosis/x/concentrated-liquidity/math/math.go

Line 184 in 2f30676

} else if sqrtPrice.LTE(sqrtPriceB) {

Suggested Design

• Change the linked bound check to be strictly less than

Acceptance Criteria

• A test case demonstrating the panic should pass
• All existing tests should pass