Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CL: swap tick boundary test vectors #5538

Closed
p0mvn opened this issue Jun 15, 2023 · 5 comments · Fixed by #5526
Closed

CL: swap tick boundary test vectors #5538

p0mvn opened this issue Jun 15, 2023 · 5 comments · Fixed by #5526
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board

Comments

@p0mvn
Copy link
Member

p0mvn commented Jun 15, 2023

Background

These are the test vectors that we would like to hit:

  • zero for one swap until tick + second zero for one swap
  • zero for one swap below tick + second zero for one swap
  • zero for one swap above tick + second zero for one swap

repeat the same combinations but second swap is one for zero

  • one for zero swap until tick + second one for zero swap
  • one for zero swap below tick + second one for zero swap
  • one for zero swap above tick + second one for zero swap

repeat the same combinations but second swap is one for zero

Acceptance Criteria

  • Test vectors covered
@p0mvn p0mvn added the F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board label Jun 15, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Jun 15, 2023
@p0mvn
Copy link
Member Author

p0mvn commented Jun 15, 2023

Additional vectors:
consider the impact of price limit on this

@p0mvn
Copy link
Member Author

p0mvn commented Jun 15, 2023

We should repeat the same vectors with tick spacing of 1 and 100 to ensure the are no edge cases around that

@p0mvn
Copy link
Member Author

p0mvn commented Jun 15, 2023

In particular, where the are ticks surrounding the tick being crossed when tick spacing is one

@AlpinYukseloglu
Copy link
Contributor

Linking this issue to ensure it's flagged in #5428

We should definitely expand the randomized swap portion of #5476 to cover this

@p0mvn
Copy link
Member Author

p0mvn commented Jun 19, 2023

Just FYI, The test vectors listed here are already covered by hand-picked values in #5526

@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to Done ✅ in Osmosis Chain Development Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants