Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually bump ibc-go: https://github.com/osmosis-labs/osmosis/pull/5031 #5273

Closed
Tracked by #4700
p0mvn opened this issue May 23, 2023 · 5 comments
Closed
Tracked by #4700

Manually bump ibc-go: https://github.com/osmosis-labs/osmosis/pull/5031 #5273

p0mvn opened this issue May 23, 2023 · 5 comments
Assignees
@stackman27

Comments

@p0mvn
Copy link
Member

p0mvn commented May 23, 2023 •
edited
Loading

  • check if newer version exists
  • review changelog and confirm no major changes preventing us from doing the upgrade
  • if none, bump up
@p0mvn p0mvn mentioned this issue May 23, 2023
Closed
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development May 23, 2023
@czarcas7ic czarcas7ic moved this from Needs Triage 🔍 to Todo 🕒 in Osmosis Chain Development May 23, 2023
@p0mvn
Copy link
Member Author

p0mvn commented May 23, 2023

Consider this version: https://github.com/cosmos/ibc-go/releases/tag/v4.4.0

@stackman27 stackman27 self-assigned this May 24, 2023
@ValarDragon
Copy link
Member

I dont think we should bump to v4.4.0, it is only doing dep updates

@stackman27
Copy link
Contributor

stackman27 commented May 25, 2023 •
edited
Loading

@p0mvn should we close this issue too considering we donot want to bump to v4.4.0 or should we go for v4.4.1?

@p0mvn
Copy link
Member Author

p0mvn commented May 26, 2023

We still need to apply the huckleberry patch since we are on v4.3.0 on main. So I think we can go straight to v4.4.1 just for the sake of being at the latest within the same major

@p0mvn
Copy link
Member Author

p0mvn commented May 26, 2023

I think this got addressed by: #5320

@p0mvn p0mvn closed this as completed May 26, 2023
@github-project-automation github-project-automation bot moved this from Todo 🕒 to Done ✅ in Osmosis Chain Development May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stackman27 stackman27

Labels
None yet
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ValarDragon @stackman27 @p0mvn