Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CL: multiple synth locks for single lock #5246

Closed
czarcas7ic opened this issue May 20, 2023 · 0 comments · Fixed by #5265
Closed

CL: multiple synth locks for single lock #5246

czarcas7ic opened this issue May 20, 2023 · 0 comments · Fixed by #5265
Assignees
Labels
C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board

Comments

@czarcas7ic
Copy link
Member

Background

The migration logic for CL requires the underlying lock to have a single synthetic lock. By skimming the code, it looks like it is possible for a lock to have multiple synthetic locks.

Suggested Design

If the above is true, we need to either:

  • refactor migration logic to accept a lock with multiple underlying synthetic locks
    or
  • if we accept that fact that people with multiple underlying synthetic locks for a single lock will not be able to migrate, we need to determine how many people this will effect. If its a lot, then we should go back to drawing board to determine best course of action.

Acceptance Criteria

One of the above paths is taken and tests are added relevant to that path.

@czarcas7ic czarcas7ic added C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board labels May 20, 2023
@czarcas7ic czarcas7ic self-assigned this May 20, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development May 20, 2023
@czarcas7ic czarcas7ic moved this from Needs Triage 🔍 to Todo 🕒 in Osmosis Chain Development May 20, 2023
@czarcas7ic czarcas7ic moved this from Todo 🕒 to Needs PR Review in Osmosis Chain Development May 23, 2023
@github-project-automation github-project-automation bot moved this from Needs PR Review to Done ✅ in Osmosis Chain Development May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant