Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CL]: Update x/concentrated-liquidity to refer to swap fee as spread factor #5243

Closed
p0mvn opened this issue May 20, 2023 · 0 comments · Fixed by #5268
Closed

[CL]: Update x/concentrated-liquidity to refer to swap fee as spread factor #5243

p0mvn opened this issue May 20, 2023 · 0 comments · Fixed by #5268
Assignees
@AlpinYukseloglu
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board

Comments

@p0mvn
Copy link
Member

p0mvn commented May 20, 2023

Background

This is a follow-up to:

We need a more intelligent search and replace in x/concentrated-liqudiity module to rename

  • message collect fee
  • fee growth on ticks
  • fee growth accumulator
  • various keys
  • variable names referring to fee

Acceptance Criteria

  • renamed fee to spread factor or spread rewards where applicable
  • readme update
@p0mvn p0mvn added the F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board label May 20, 2023
@p0mvn p0mvn mentioned this issue May 20, 2023
Merged
@AlpinYukseloglu AlpinYukseloglu self-assigned this May 22, 2023
This was referenced May 23, 2023
Merged
Closed
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development May 29, 2023
@AlpinYukseloglu AlpinYukseloglu moved this from Needs Triage 🔍 to In Progress🏃 in Osmosis Chain Development May 29, 2023
@AlpinYukseloglu AlpinYukseloglu changed the title CL: Update x/concentrated-liquidity to refer to swap fee as spread factor [CL]: Update x/concentrated-liquidity to refer to swap fee as spread factor May 29, 2023
@AlpinYukseloglu AlpinYukseloglu moved this from In Progress🏃 to Needs PR Review in Osmosis Chain Development May 29, 2023
@github-project-automation github-project-automation bot moved this from Needs PR Review to Done ✅ in Osmosis Chain Development May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlpinYukseloglu AlpinYukseloglu

Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
2 participants
@p0mvn @AlpinYukseloglu