You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Why do we want this? Seems like it just avoids the fn being printed in the stacktrace, not sure why thats a feature for us? https://pkg.go.dev/testing#T.Helper
I'd prefer to not have to think about this personally.
hmm, on the second look, I now see that adding t.Helper there does not do anything useful, because those functions internally do not fail the test (aka: call t.FailNow, t.Fatal etc), so adding a t.Helper mark is a no-op. I just wanted to remove the linting warnings, but now that I revisited this, I decided to simply disable them for those specific functions
thank you!
pysel
changed the title
osmomath: mark test functions as helpers
osmomath: disable thelper for some testing functions
May 12, 2023
Background
A few functions in
osmomath/decimal.go
are test helper functions, but they are not marked as helper functionsSuggested Design
mark these functions as helpers
Acceptance Criteria
helper functions marked
The text was updated successfully, but these errors were encountered: