Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProtoRev v16 Tracking Issue #4997

Closed
3 tasks done
Tracked by #4700
NotJeremyLiu opened this issue Apr 24, 2023 · 7 comments
Closed
3 tasks done
Tracked by #4700

ProtoRev v16 Tracking Issue #4997

NotJeremyLiu opened this issue Apr 24, 2023 · 7 comments
Labels
protorev All things related to x/protorev

Comments

@NotJeremyLiu
Copy link
Contributor

NotJeremyLiu commented Apr 24, 2023

Background

Tracking issue for all things related to ProtoRev for v16 upgrade

Concentrated Liquidity and ProtoRev Module Changes:

Upgrades and ProtoRev Module Changes:

ProtoRev Module Changes:

@NotJeremyLiu NotJeremyLiu added the protorev All things related to x/protorev label Apr 24, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Apr 24, 2023
@p0mvn
Copy link
Member

p0mvn commented May 14, 2023

Hi @NotJeremyLiu . Is this up-to-date?

@NotJeremyLiu
Copy link
Contributor Author

Hey @p0mvn ,

This is up to date.

I still need to turn the hook-based logic from a branch into a PR (need to add tests still), and the dev fee payout / updating is ready for review from Osmosis side (will add some comments on the PR to focus on a point that I would like extra eyes on.

@NotJeremyLiu
Copy link
Contributor Author

Looks like I need to tackle some conflict issues now with #4827, can tackle tomorrow

@p0mvn
Copy link
Member

p0mvn commented May 14, 2023

Sweet. Thanks for the update

@p0mvn p0mvn moved this from Needs Triage 🔍 to Todo 🕒 in Osmosis Chain Development May 23, 2023
@NotJeremyLiu NotJeremyLiu changed the title ProtoRev v16 Tracking Issue (DRAFT) ProtoRev v16 Tracking Issue May 23, 2023
@NotJeremyLiu
Copy link
Contributor Author

@p0mvn the two PRs in this issue are r4r now, added comments in the #4827 specifically would appreciate a focus on how the upgrade is handled, as I believe it is incorrect (e2e tests fail) but am at my limit of knowledge of how to fix it.

@p0mvn
Copy link
Member

p0mvn commented May 24, 2023

Thanks for the update @NotJeremyLiu . @stackman27 is looking into the e2e issue

@czarcas7ic
Copy link
Member

Removing this tracking issue from sprint 32 since we are tracking the sub components in this sprint

@p0mvn p0mvn closed this as completed Jun 21, 2023
@github-project-automation github-project-automation bot moved this from Todo 🕒 to Done ✅ in Osmosis Chain Development Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protorev All things related to x/protorev
Projects
Archived in project
Development

No branches or pull requests

3 participants