Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat Request for ProtoRev: Add input/output coins to CL Swap listener #4945

Closed
NotJeremyLiu opened this issue Apr 17, 2023 · 0 comments · Fixed by #4950
Closed

Feat Request for ProtoRev: Add input/output coins to CL Swap listener #4945

NotJeremyLiu opened this issue Apr 17, 2023 · 0 comments · Fixed by #4950
Assignees
Labels
protorev All things related to x/protorev

Comments

@NotJeremyLiu
Copy link
Contributor

NotJeremyLiu commented Apr 17, 2023

Background

  • For v16, ProtoRev will be using a hook-based approach to backrunning transactions, instead of the current message parsing based approach.

  • The information ProtoRev needs is the token(s) in and token(s) out from a given swap.

  • This information is currently provided in the AfterCFMMSwap hook for the gamm module

    func (h MultiGammHooks) AfterCFMMSwap(ctx sdk.Context, sender sdk.AccAddress, poolId uint64, input sdk.Coins, output sdk.Coins) {

  • But is not provided in the AfterConcentratedPoolSwap listener in the concentrated-liquidity module

    func (l ConcentratedLiquidityListeners) AfterConcentratedPoolSwap(ctx sdk.Context, sender sdk.AccAddress, poolId uint64) {

  • This issue is opened to request that input/output coins for a swap are provided in the AfterConcentratedPoolSwap listener to allow protorev to fully move to a hook-based approach for extracting swaps.

Suggested Design

  • Provide input/output coins for the swap in the AfterConcentratedPoolSwap listener, similar to the gamm module swap hook.
@NotJeremyLiu NotJeremyLiu added F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board protorev All things related to x/protorev labels Apr 17, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Apr 17, 2023
@p0mvn p0mvn removed the F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board label Apr 24, 2023
@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to Done ✅ in Osmosis Chain Development May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protorev All things related to x/protorev
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants