Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CL Incentives] Make collectIncentives return forfeited amount #4736

Closed
Tracked by #3991
AlpinYukseloglu opened this issue Mar 24, 2023 · 0 comments · Fixed by #4996
Closed
Tracked by #3991

[CL Incentives] Make collectIncentives return forfeited amount #4736

AlpinYukseloglu opened this issue Mar 24, 2023 · 0 comments · Fixed by #4996
Assignees
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board

Comments

@AlpinYukseloglu
Copy link
Contributor

Background

We separated out tracking of claimed and forfeited incentives in #4735, but still only return the claimed amount for the CollectIncentives message. It would be a good quality of life improvement to return forfeitedIncentives at these higher level functions as well.

Suggested Design

  • Pick up forfeitedIncentives field returned by collectIncentivesForPosition in collectIncentives and return it
  • Update message, tests, and any broken wiring

Acceptance Criteria

  • All new and existing tests should pass
@AlpinYukseloglu AlpinYukseloglu added the F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board label Mar 24, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Mar 24, 2023
@p0mvn p0mvn moved this from Needs Triage 🔍 to Todo 🕒 in Osmosis Chain Development Mar 27, 2023
@czarcas7ic czarcas7ic self-assigned this Apr 24, 2023
@czarcas7ic czarcas7ic moved this from Todo 🕒 to In Progress🏃 in Osmosis Chain Development Apr 24, 2023
@czarcas7ic czarcas7ic moved this from In Progress🏃 to Todo 🕒 in Osmosis Chain Development Apr 24, 2023
@czarcas7ic czarcas7ic moved this from Todo 🕒 to Needs PR Review in Osmosis Chain Development Apr 24, 2023
@github-project-automation github-project-automation bot moved this from Needs PR Review to Done ✅ in Osmosis Chain Development Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants