Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CL]: Improve KVStore Entry #4733

Closed
czarcas7ic opened this issue Mar 24, 2023 · 0 comments · Fixed by #5237
Closed

[CL]: Improve KVStore Entry #4733

czarcas7ic opened this issue Mar 24, 2023 · 0 comments · Fixed by #5237
Assignees
Labels
C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board

Comments

@czarcas7ic
Copy link
Member

Background

The current Owner | Pool ID | Position ID -> Position ID KVStore returns values like so:

addr1|1|1->1
addr1|1|2->2
addr1|2|3->3
addr2|1|4->4
addr2|1|5->5

We should instead key Owner | Pool ID -> list of Position IDs like so:

addr1|1|->[1, 2]
addr1|2|->[3]
addr2|1|->[4,5]

Another improvement that can be made is with with current Pool ID -> Position ID mapping, and switching it to a Pool ID -> List of Position IDs mapping as well (similar to what was explained above)

Suggested Design

  • Change the store logic in createPosition and removePosition
  • Update tests to ensure any new logic added is covered
@czarcas7ic czarcas7ic added C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board labels Mar 24, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Mar 24, 2023
@p0mvn p0mvn moved this from Needs Triage 🔍 to Todo 🕒 in Osmosis Chain Development Mar 26, 2023
@czarcas7ic czarcas7ic self-assigned this Mar 26, 2023
@p0mvn p0mvn moved this from Todo 🕒 to Needs Triage 🔍 in Osmosis Chain Development Apr 26, 2023
@czarcas7ic czarcas7ic moved this from Needs Triage 🔍 to Needs PR Review in Osmosis Chain Development May 17, 2023
@github-project-automation github-project-automation bot moved this from Needs PR Review to Done ✅ in Osmosis Chain Development May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Projects
Archived in project
1 participant