Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Routing] Pre-swap unwrapping #4728

Closed
Tracked by #4344
nicolaslara opened this issue Mar 24, 2023 · 0 comments · Fixed by #4809
Closed
Tracked by #4344

[Routing] Pre-swap unwrapping #4728

nicolaslara opened this issue Mar 24, 2023 · 0 comments · Fixed by #4809
Assignees
@nicolaslara
Labels
F: Crosschain Swaps

Comments

@nicolaslara
Copy link
Contributor

Epic: #4344
Continuation of #4694

Background

The contract is using the registries to unwrap tokens when sending. It should also do it before sending so any double-wrapped tokens are unwrapped first.

Suggested Design

  • unwrap

Acceptance Criteria

  • tests
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Mar 24, 2023
@nicolaslara nicolaslara mentioned this issue Mar 24, 2023
Open
@nicolaslara nicolaslara changed the title Routing+XCS: Pre-swap unwrapping [Routing]: Pre-swap unwrapping Mar 24, 2023
@nicolaslara nicolaslara changed the title [Routing]: Pre-swap unwrapping [Routing] Pre-swap unwrapping Mar 24, 2023
@nicolaslara nicolaslara self-assigned this Mar 24, 2023
@nicolaslara nicolaslara moved this from Needs Triage 🔍 to Todo 🕒 in Osmosis Chain Development Mar 27, 2023
@nicolaslara nicolaslara moved this from Todo 🕒 to In Progress🏃 in Osmosis Chain Development Mar 30, 2023
@nicolaslara nicolaslara mentioned this issue Mar 31, 2023
Merged
@nicolaslara nicolaslara moved this from In Progress🏃 to Needs PR Review in Osmosis Chain Development Apr 6, 2023
@github-project-automation github-project-automation bot moved this from Needs PR Review to Done ✅ in Osmosis Chain Development Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolaslara nicolaslara

Labels
F: Crosschain Swaps
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unwrap badly wrapped tokens before a XCS osmosis-labs/osmosis
1 participant
@nicolaslara