Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI arguments for JoinSwapShareAmountOut are in incorrect order #3813

Closed
larry0x opened this issue Dec 21, 2022 · 0 comments · Fixed by #3942
Closed

CLI arguments for JoinSwapShareAmountOut are in incorrect order #3813

larry0x opened this issue Dec 21, 2022 · 0 comments · Fixed by #3942

Comments

@larry0x
Copy link
Contributor

larry0x commented Dec 21, 2022

System information

Osmosis version: 13.1.1
OS & Version: macOS
Commit hash: 7568297f11160cb8b09cdb99dd737b953648b242

Expected behaviour

According to CLI help text, the 2nd argument should be token_in_max_amount and the 3rd being share_out_amount:

$ osmosisd tx gamm join-swap-share-amount-out -h

join swap share amount out

Usage:
  osmosisd tx gamm join-swap-share-amount-out [token-in-denom] [token-in-max-amount] [share-out-amount] [flags]

Actual behaviour

Transactions are composed using the 2rd argument as share_out_amount and the 3rd as token_in_max_amount.

Steps to reproduce the behaviour

Running the following command, I would expect a transaction to deposit at most 12345uosmo with an share output amount of 67890gamm/pool/678.

However, as shown below, a transaction depositing at most 67890uosmo with the share output amount of 12345gamm/pool/678 is composed.

$ osmosisd tx gamm join-swap-share-amount-out uosmo 12345 67890 --pool-id 678 --from keyname

Enter keyring passphrase: [hidden]

{"body":{"messages":[{"@type":"/osmosis.gamm.v1beta1.MsgJoinSwapShareAmountOut","sender":"osmo1...","pool_id":"678","token_in_denom":"uosmo","share_out_amount":"12345","token_in_max_amount":"67890"}],"memo":"","timeout_height":"0","extension_options":[],"non_critical_extension_options":[]},"auth_info":{"signer_infos":[],"fee":{"amount":[],"gas_limit":"350000","payer":"","granter":""}},"signatures":[]}

confirm transaction before signing and broadcasting [y/N]: ^C
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant