Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[x/gamm][stableswap]: Panic catch core operations at keeper level #3277

Closed
Tracked by #1451
, #3328
...
AlpinYukseloglu opened this issue Nov 7, 2022 · 1 comment · Fixed by #3312
Closed
Tracked by #1451
, #3328
...

[x/gamm][stableswap]: Panic catch core operations at keeper level #3277

AlpinYukseloglu opened this issue Nov 7, 2022 · 1 comment · Fixed by #3312
Labels
C:stableswap C:x/gamm Changes, features and bugs related to the gamm module.

Comments

@AlpinYukseloglu
Copy link
Contributor

Background

We currently panic when there is an issue with the solver or core AMM math. We should catch these panics at the keeper level and return errors as we do with spot prices for balancer pools.

Suggested Design

  • Catch panics and turn into errors with appropriate error messages

Acceptance Criteria

  • All new and existing tests pass
@AlpinYukseloglu AlpinYukseloglu added C:x/gamm Changes, features and bugs related to the gamm module. C:stableswap labels Nov 7, 2022
This was referenced Nov 7, 2022
Closed
Closed
@pysel
Copy link
Member

pysel commented Nov 9, 2022

hello @AlpinYukseloglu is this available to work on?

@ValarDragon ValarDragon mentioned this issue Nov 9, 2022
Merged
@AlpinYukseloglu AlpinYukseloglu mentioned this issue Nov 10, 2022
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:stableswap C:x/gamm Changes, features and bugs related to the gamm module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add keeper level panic catches osmosis-labs/osmosis
2 participants
@pysel @AlpinYukseloglu