Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[x/gamm][stableswap]: Switch solver error tolerance to be geometric #3254

Closed
Tracked by #1451
, #3328
...
AlpinYukseloglu opened this issue Nov 5, 2022 · 0 comments
Closed
Tracked by #1451
, #3328
...

[x/gamm][stableswap]: Switch solver error tolerance to be geometric #3254

AlpinYukseloglu opened this issue Nov 5, 2022 · 0 comments
Assignees
@AlpinYukseloglu
Labels
C:stableswap C:x/gamm Changes, features and bugs related to the gamm module.

Comments

@AlpinYukseloglu
Copy link
Contributor

Background

Additive error tolerance fails to follow expected behavior at limits. This especially becomes an issue when we enforce a sizable scaling factor multiplier, so we should switch our error tolerance to be geometric.

Suggested Design

  • Replace additive tolerance with 10^-24 multiplicative tolerance

Acceptance Criteria

  • All existing tests should pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlpinYukseloglu AlpinYukseloglu

Labels
C:stableswap C:x/gamm Changes, features and bugs related to the gamm module.
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlpinYukseloglu