Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move binary search to its own package #3251

Closed
ValarDragon opened this issue Nov 4, 2022 · 1 comment · Fixed by #3763
Closed

Move binary search to its own package #3251

ValarDragon opened this issue Nov 4, 2022 · 1 comment · Fixed by #3763
Assignees
@ValarDragon
Labels
Good first issue

Comments

@ValarDragon
Copy link
Member

Background

We should move binary search out of osmoutils into its own package. Its a nice self-contained, reusable unit. I suggest we make this a sub-package within osmomath.

Acceptance Criteria

It is contained in its own subpackage
@ValarDragon ValarDragon self-assigned this Nov 4, 2022
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Nov 4, 2022
@ValarDragon ValarDragon mentioned this issue Nov 16, 2022
Closed
@ValarDragon
Copy link
Member Author

To do this issue, see #3405 , should be a pretty simple move

@ValarDragon ValarDragon mentioned this issue Dec 16, 2022
Merged
Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ValarDragon ValarDragon

Labels
Good first issue
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
1 participant
@ValarDragon