Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CL][Misc]: improve logarithm implementation #3086

Closed
p0mvn opened this issue Oct 21, 2022 · 0 comments · Fixed by #2788
Closed

[CL][Misc]: improve logarithm implementation #3086

p0mvn opened this issue Oct 21, 2022 · 0 comments · Fixed by #2788
Assignees
@p0mvn
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board T:task ⚙️ A task belongs to a story
Milestone
CL4: Precise Loga...

Comments

@p0mvn
Copy link
Member

p0mvn commented Oct 21, 2022

Background

We are currently using the following logarithm approximation implementation: #2788

This is not sufficient for production. We need to finalize the logarithm implementation to be accurate.

Suggested Design

Continue on the approaches in #2788

Acceptance Criteria

  • logarithm is accurate
  • thoroughly tested with links to wolfram added
@p0mvn p0mvn added the F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board label Oct 21, 2022
@p0mvn p0mvn self-assigned this Oct 21, 2022
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Oct 21, 2022
@p0mvn p0mvn added the T:task ⚙️ A task belongs to a story label Oct 21, 2022
This was referenced Oct 21, 2022
Closed
Merged
Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p0mvn p0mvn

Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board T:task ⚙️ A task belongs to a story
Projects
Osmosis Chain Development
Archived in project
Milestone
CL4: Precise Logarithm, Improved Wiri...
Development

Successfully merging a pull request may close this issue.

feat(osmomath): log2 approximation osmosis-labs/osmosis
1 participant
@p0mvn