Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[x/gamm][stableswap]: Increase BigDec precision even further to accommodate large 4-asset pools #3008

Closed
Tracked by #1451
AlpinYukseloglu opened this issue Oct 16, 2022 · 1 comment
Closed
Tracked by #1451

[x/gamm][stableswap]: Increase BigDec precision even further to accommodate large 4-asset pools #3008

AlpinYukseloglu opened this issue Oct 16, 2022 · 1 comment
Labels
C:stableswap C:x/gamm Changes, features and bugs related to the gamm module.

Comments

@AlpinYukseloglu
Copy link
Contributor

Background

Even with 36 decimal places of precision, large 4-asset pools still overflow. We should increase precision to whatever number allows us to comfortably support $100B per asset in a 4-asset pool.

Suggested Design

  • 72 precision should be enough, but we might need to increase it even further

Acceptance Criteria

  • All new and existing tests pass
@AlpinYukseloglu AlpinYukseloglu added C:x/gamm Changes, features and bugs related to the gamm module. C:stableswap labels Oct 16, 2022
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Oct 16, 2022
This was referenced Oct 16, 2022
Closed
Closed
@AlpinYukseloglu
Copy link
Contributor Author

Update: now that we calculate our multi-asset CFMM using k' = k / u, this is no longer an issue and 36 precision allows us plenty capacity

Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:stableswap C:x/gamm Changes, features and bugs related to the gamm module.
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlpinYukseloglu