Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[x/gamm][stableswap] Add multi-asset and stableswap test cases to TestMaximalExactRatioJoin #2911

Closed
p0mvn opened this issue Sep 30, 2022 · 1 comment
Closed

[x/gamm][stableswap] Add multi-asset and stableswap test cases to TestMaximalExactRatioJoin #2911

p0mvn opened this issue Sep 30, 2022 · 1 comment
Labels
C:x/gamm Changes, features and bugs related to the gamm module. T:tests
Milestone
v13

Comments

@p0mvn
Copy link
Member

p0mvn commented Sep 30, 2022

Background

Currently, the direct test cases for MaximalExactRatioJoin only operate on balancer pools and two asset-pools.

osmosis/x/gamm/pool-models/internal/cfmm_common/lp_test.go

Line 142 in 3c7eab9

func TestMaximalExactRatioJoin(t *testing.T) {

Suggested Design

We should add more test cases with the stableswap pool as well as multiple assets

Acceptance Criteria

  • TestMaximamlExactRatioJoin is generalized to work with the stableswap pool
  • stableswap pool test cases added
  • multi-asset tests (at least 3)
@p0mvn p0mvn added the C:x/gamm Changes, features and bugs related to the gamm module. label Sep 30, 2022
@p0mvn p0mvn added this to the v13 milestone Sep 30, 2022
@p0mvn p0mvn added the T:tests label Sep 30, 2022
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Sep 30, 2022
@p0mvn
Copy link
Member Author

p0mvn commented Sep 30, 2022

Seems that this is a duplicate of #1406 and #1369

@p0mvn p0mvn closed this as completed Sep 30, 2022
Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:x/gamm Changes, features and bugs related to the gamm module. T:tests
Projects
Osmosis Chain Development
Archived in project
Milestone
v13
Development

No branches or pull requests
1 participant
@p0mvn