Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stableswap]: Add checks for invalid cfmm inputs #2694

Closed
Tracked by #1451
AlpinYukseloglu opened this issue Sep 10, 2022 · 0 comments · Fixed by #2695
Closed
Tracked by #1451

[stableswap]: Add checks for invalid cfmm inputs #2694

AlpinYukseloglu opened this issue Sep 10, 2022 · 0 comments · Fixed by #2695
Assignees
@AlpinYukseloglu
Labels
C:x/gamm Changes, features and bugs related to the gamm module.

Comments

@AlpinYukseloglu
Copy link
Contributor

Background

While testing our stableswap CFMMs (both two-asset and multi), I noticed that given their complexity it is possible for certain really weird inputs to get passed into the solvers that go completely uncaught. Both for security reasons and for more time-effective testing/bug squashing, I think we should implement validity checks for inputs to (and outputs of) the CFMM solvers.

Suggested Design

  • Ensure invalid inputs are caught (e.g. negative reserve values or inputs)

Acceptance Criteria

  • New checks are tested & existing tests pass
@AlpinYukseloglu AlpinYukseloglu added the C:x/gamm Changes, features and bugs related to the gamm module. label Sep 10, 2022
@AlpinYukseloglu AlpinYukseloglu self-assigned this Sep 10, 2022
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Sep 10, 2022
This was referenced Sep 10, 2022
Merged
Closed
Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlpinYukseloglu AlpinYukseloglu

Labels
C:x/gamm Changes, features and bugs related to the gamm module.
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[stableswap]: Add checks for invalid cfmm inputs osmosis-labs/osmosis
1 participant
@AlpinYukseloglu