Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[x/gamm][stableswap] Implement JoinPoolNoSwap and CalcJoinPoolNoSwapShares abstractions #2376

Closed
Tracked by #1451
AlpinYukseloglu opened this issue Aug 11, 2022 · 1 comment
Closed
Tracked by #1451

[x/gamm][stableswap] Implement JoinPoolNoSwap and CalcJoinPoolNoSwapShares abstractions #2376

AlpinYukseloglu opened this issue Aug 11, 2022 · 1 comment
Assignees
@p0mvn
Labels
C:x/gamm Changes, features and bugs related to the gamm module.

Comments

@AlpinYukseloglu
Copy link
Contributor

Background

Our implementation for issue #2128 left out the relevant changes for stableswap for the sake of time. We should implement and test this abstraction asap for stableswap to prevent it from breaking future work as we pick stableswap work back up.

Suggested Design

Acceptance Criteria

  • All existing and new tests pass
@AlpinYukseloglu AlpinYukseloglu added the C:x/gamm Changes, features and bugs related to the gamm module. label Aug 11, 2022
@AlpinYukseloglu AlpinYukseloglu mentioned this issue Aug 11, 2022
Merged
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Aug 11, 2022
@AlpinYukseloglu AlpinYukseloglu mentioned this issue Aug 25, 2022
Closed
55 tasks
@AlpinYukseloglu AlpinYukseloglu self-assigned this Sep 26, 2022
@p0mvn p0mvn assigned p0mvn and unassigned AlpinYukseloglu Sep 30, 2022
@p0mvn
Copy link
Member

p0mvn commented Sep 30, 2022

@AlpinYukseloglu FYI, I'm on this

@p0mvn p0mvn mentioned this issue Oct 1, 2022
Closed
Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p0mvn p0mvn

Labels
C:x/gamm Changes, features and bugs related to the gamm module.
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
2 participants
@p0mvn @AlpinYukseloglu