Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go module version v10 should be updated to true/tagged version v11 #2366

Closed
08d2 opened this issue Aug 11, 2022 · 3 comments
Closed

Go module version v10 should be updated to true/tagged version v11 #2366

08d2 opened this issue Aug 11, 2022 · 3 comments
Assignees

Comments

@08d2
Copy link

08d2 commented Aug 11, 2022

The major version used in a git tag must be the same as the Go module version (defined in go.mod) at that revision. Otherwise, that rev isn't importable.

$ go get github.com/osmosis-labs/osmosis/v10@latest
go: added github.com/osmosis-labs/osmosis/v10 v10.1.1
$ go get github.com/osmosis-labs/osmosis/[email protected]
go: github.com/osmosis-labs/osmosis/[email protected]: invalid version: module path includes a major version suffix, so major version must match
$ go get github.com/osmosis-labs/osmosis/v11@latest
go: module github.com/osmosis-labs/osmosis@latest found (v1.0.4), but does not contain package github.com/osmosis-labs/osmosis/v11

So the change here would be

diff --git a/go.mod b/go.mod
index 000c6c61..fba340f1 100644
--- a/go.mod
+++ b/go.mod
@@ -1,4 +1,4 @@
-module github.com/osmosis-labs/osmosis/v10
+module github.com/osmosis-labs/osmosis/v11
 
 go 1.18
 

plus whatever import paths need to be updated.

@czarcas7ic
Copy link
Member

Thanks for flagging! We decided to change the import paths once TWAP is in #2304

@p0mvn do you think we at a point now where we can reopen this PR?

@p0mvn
Copy link
Member

p0mvn commented Aug 11, 2022

Yes, I will work on this. Will address: #2367 first to easily update both main and v11.x

@ValarDragon
Copy link
Member

v11.0.1 went out that fixes this!

Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants