Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gamm: Make test case for GetPoolDenoms #2200

Closed
1 task
ValarDragon opened this issue Jul 22, 2022 · 0 comments · Fixed by #2240
Closed
1 task

gamm: Make test case for GetPoolDenoms #2200

ValarDragon opened this issue Jul 22, 2022 · 0 comments · Fixed by #2240
Assignees
@stackman27
Milestone
V12 Blockers

Comments

@ValarDragon
Copy link
Member

Background

In #2193 , I merged it pre-review when I shouldn't have. One item that came up is we need to make unit tests for the newly added gamm GetPoolsDenom function.

Acceptance Criteria

  • Write unit tests for the GammKeeper.GetPoolsDenom function
@ValarDragon ValarDragon moved this to Needs Review 🔍 in Osmosis Chain Development Jul 22, 2022
@ValarDragon ValarDragon added this to the V11 Blockers milestone Jul 22, 2022
@stackman27 stackman27 self-assigned this Jul 25, 2022
@stackman27 stackman27 mentioned this issue Jul 27, 2022
Merged
@mergify mergify bot closed this as completed in cf39ea3 Jul 28, 2022
Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stackman27 stackman27

Labels
None yet
Projects
Osmosis Chain Development
Archived in project
Milestone
V12 Blockers
Development

Successfully merging a pull request may close this issue.

[Test] gamm: Make test case for GetPoolDenoms stackman27/osmosis
2 participants
@ValarDragon @stackman27