Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move wasm-bindings code out of app #1667

Closed
ValarDragon opened this issue Jun 4, 2022 · 2 comments · Fixed by #1673
Closed

Move wasm-bindings code out of app #1667

ValarDragon opened this issue Jun 4, 2022 · 2 comments · Fixed by #1673
Assignees
@vuong177

Comments

@ValarDragon
Copy link
Member

ValarDragon commented Jun 4, 2022 •
edited
Loading

Background

Currently the wasm package for bindings is in a package within app. I think it stands on its own as a wasm-bindings package in the top level directory.

I feel like it being in the app package is a different structure than I would a-priori expect coming into the repository.

Suggested Design

Refactor /app/wasm to /wasm-bindings
@daniel-farina daniel-farina moved this to Needs Review 🔍 in Osmosis Chain Development Jun 4, 2022
@vuong177
Copy link
Contributor

vuong177 commented Jun 5, 2022

Hi @ValarDragon, could I work on this ?

@ValarDragon
Copy link
Member Author

Sure!

@vuong177 vuong177 mentioned this issue Jun 5, 2022
Merged
Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vuong177 vuong177

Labels
None yet
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move wasm-bindings code out of app
2 participants
@ValarDragon @vuong177