Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate ExtendLockup hooks #1404

Closed
ValarDragon opened this issue May 4, 2022 · 0 comments · Fixed by #1405
Closed

Investigate ExtendLockup hooks #1404

ValarDragon opened this issue May 4, 2022 · 0 comments · Fixed by #1405
Assignees

Comments

@ValarDragon
Copy link
Member

ValarDragon commented May 4, 2022

We need to look further into the hook calls for MsgLockupExtendDuration.

It currently calls OnTokensUnlocked and OnTokensLocked. I don't think this is right, it should instead get a new hook. This is because something like superfluid shouldn't think "start undoing superfluid lock" upon seeing the unlock hook for instance, its not the lock creator signalling intent to unwind. (In fact its the opposite!)

I suggest we make a new hook called OnLockExtended, and use that here.

Originally posted by @ValarDragon in #1253 (comment)

@daniel-farina daniel-farina moved this to 🔍 Needs Review in Osmosis Chain Development May 4, 2022
@mconcat mconcat self-assigned this May 4, 2022
Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants