Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move internalChain and internalValidator to internal package #1370

Closed
czarcas7ic opened this issue Apr 28, 2022 · 3 comments
Closed

test: move internalChain and internalValidator to internal package #1370

czarcas7ic opened this issue Apr 28, 2022 · 3 comments

Comments

@czarcas7ic
Copy link
Member

As suggested by @p0mvn here, we should move the internalChain and internalValidator structs to an internal package. This prevents the need for unnecessary prefixes and simplifies the chain package.

Also see https://dave.cheney.net/2019/10/06/use-internal-packages-to-reduce-your-public-api-surface

@ValarDragon
Copy link
Member

I believe this is obsoleted by roman's e2e spike?

@p0mvn p0mvn added the C:e2e label Jul 4, 2022
@p0mvn
Copy link
Member

p0mvn commented Jul 4, 2022

My e2e spike didn't cover this. I think we might want to keep this open and revisit after the spike is fully merged.

In my view, this is a low-priority issue. Could be a good first issue for someone to onboard on e2e tests though

@ValarDragon
Copy link
Member

i think this has been obsoleted

Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants