Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/lock: Investigate setLockAndResetLockRefs #1275

Closed
mattverse opened this issue Apr 18, 2022 · 0 comments · Fixed by #1951
Closed

x/lock: Investigate setLockAndResetLockRefs #1275

mattverse opened this issue Apr 18, 2022 · 0 comments · Fixed by #1951

Comments

@mattverse
Copy link
Member

mattverse commented Apr 18, 2022

cref: #1253 (comment)

setLockAndResetLockRefs does not actually reset lock refs as the method name implies, instead simply resets only the lock itself. We need to investigate whether other methods using setLockAndResetLockRefs do not require lock refs to get actually deleted or reset. If not, we can simply take the approach where we change the method name to something like setLockAndResetLock.

However, if we were expected to be deleting/ resetting the lock refs whenever we were calling setLockAndResetLockRefs, we would have to:

  • modify the method itself so that it resets lock refs as well,
  • check if we need to delete old lock refs.
@daniel-farina daniel-farina moved this to 🔍 Needs Review in Osmosis Chain Development Apr 18, 2022
Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant