Fix filtered paginate in the incentives module

[xBalbinus]

FilteredPaginate does pagination of all the results in the PrefixStore based on the provided PageRequest.

We need to make the incentives module follow this

https://github.com/cosmos/cosmos-sdk/blob/master/types/query/filtered_pagination.go

Please feel free to add more details @ValarDragon

[hieuvubk]

@xBalbinus
did this issue close? I see incentives grpc_query already followed filter logic above

[xBalbinus]

I don't think this issue was officially closed, if it already follows then closing is no problem

[hieuvubk]

@ValarDragon can u add more details?

[ValarDragon]

Theres a few queries in the incentives modules that just do filtered paginate incorrectly, https://github.com/osmosis-labs/osmosis/blob/main/x/incentives/keeper/grpc_query.go#L124-L132

Its getting all active gauges and filtering, inside the loop.

That loop should instead be reading off the key / value, and seeing if its valid. Rather than reading all of it.

But to be honest, most of the filtered paginate calls in that file are suspicious / wrong. (E.g. a lot that don't do any filtering!)

[hieuvubk]

@xBalbinus @ValarDragon could u take a look at this pr. I think it can close this issue. Thank u so much!

[xBalbinus]

A kind reminder that Bez commented something you may want to change, otherwise I defer to @ValarDragon’s judgement because I have less context