Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken query for x/superfluid total_superfluid_delegations #1080

Closed
mattverse opened this issue Mar 12, 2022 · 1 comment
Closed

Broken query for x/superfluid total_superfluid_delegations #1080

mattverse opened this issue Mar 12, 2022 · 1 comment
Assignees

Comments

@mattverse
Copy link
Member

Current superfluid module does not delete intermediary accounts that are not being used(intermediary accounts without any delegations for superfluid).

Meanwhile, https://github.com/osmosis-labs/osmosis/blob/main/x/superfluid/keeper/grpc_query.go#L290-L319 TotalSuperfluidDelegations iterate through all intermediary accounts, and omits and error if there aren't delegations for the intermediary account.

Quick fix I propose: simply do not omit an error if delegation not found and pass, we might want further discussions on if we want to keep intermediary accounts or not in the future

@mattverse mattverse self-assigned this Mar 12, 2022
@ValarDragon
Copy link
Member

The proposed quick fix sounds great to me!

We'll have to think through edge cases around rounding before we can delete the intermediate account entirely in a future state machine change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants