Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator tags are often wrong in the transit tree #4944

Closed
bhousel opened this issue Mar 8, 2021 · 4 comments
Closed

operator tags are often wrong in the transit tree #4944

bhousel opened this issue Mar 8, 2021 · 4 comments

Comments

@bhousel
Copy link
Member

bhousel commented Mar 8, 2021

Thanks @kjonosm for raising this:

For each transit network collected from the planet, the operator value is automatically added by just duplicating the network value. In many cases this is a mistake and leads to wrong data. See e.g. following networks where the operator tag in nsi is just a copy of the network tag, deviating from the actual tagging in OSM you can compare in the given overpass turbo links:

Ah yeah I see now. Since so many are wrong, I think I'm just going to remove all the operator values from the transit tree, and people will need to put them back manually. This is annoying and I feel bad about it, but at least it will prevent the validator from pushing wrong tags. I'm going to open a new issue for it, so everyone knows..

Originally posted by @bhousel in #4543 (comment)

@kjonosm
Copy link
Collaborator

kjonosm commented Mar 8, 2021

Is it worth keeping existing operator data in nsi when different from network tag?

@michaelblyons
Copy link
Collaborator

Is it worth keeping existing operator data in nsi when different from network tag?

Yes, please.

@bhousel
Copy link
Member Author

bhousel commented Mar 8, 2021

Is it worth keeping existing operator data in nsi when different from network tag?

Ok, I can do that (in other words, only remove the operator if it is the same as network because this may be have been added wrongly).

@bhousel
Copy link
Member Author

bhousel commented Mar 8, 2021

Let me know if it looks better now! I changed the script so that new collected items won't be set up like this by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants