Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error code !=0 returned if ENABLE_PDF_EXPORT not defined with scrict mode #99

Open
anb0s opened this issue Feb 9, 2022 · 2 comments · May be fixed by #105
Open

error code !=0 returned if ENABLE_PDF_EXPORT not defined with scrict mode #99

anb0s opened this issue Feb 9, 2022 · 2 comments · May be fixed by #105

Comments

@anb0s
Copy link

anb0s commented Feb 9, 2022

We have shared configuration for mkdocs with and without PDF generate.

  1. build without PDF (ENABLE_PDF_EXPORT is not set) is executed with --strict mode
  2. build with PDF (ENABLE_PDF_EXPORT is set) is executed without --strict mode

the 1. returns message:

WARNING  -  without generate PDF(set environment variable ENABLE_PDF_EXPORT to 1 to enable)

but the returne code is not 0 and we cannot check if strict mode detected issues.
js94x added a commit to js94x/mkdocs-with-pdf that referenced this issue Mar 10, 2022
@js94x
Switch from warn to info error level
5ae975f 
This commit fixes orzih#99
@js94x js94x linked a pull request Mar 10, 2022 that will close this issue
Open
@js94x
Copy link

js94x commented Mar 10, 2022

I experienced the same behaviour and created a PR to switch error level to info instead: #105

@anb0s anb0s changed the title error code !=0 retrned if ENABLE_PDF_EXPORT not defined with scrict mode error code !=0 returned if ENABLE_PDF_EXPORT not defined with scrict mode Sep 16, 2022
@volks73
Copy link

volks73 commented Feb 23, 2023

I am experiencing the same behavior. Would it be possible to get #105 reviewed and merged? Is there a work around in the mean time?

domWalters pushed a commit to domWalters/mkdocs-to-pdf that referenced this issue Jan 27, 2024
@js94x @domWalters
Switch from warn to info error level
3049b38 
This commit fixes orzih#99
@domWalters domWalters mentioned this issue Jan 27, 2024
Merged
domWalters pushed a commit to domWalters/mkdocs-to-pdf that referenced this issue Jan 28, 2024
@js94x @domWalters
Switch from warn to info error level
232e025 
This commit fixes orzih#99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch from warn to info error level js94x/mkdocs-with-pdf
3 participants
@anb0s @volks73 @js94x