Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make prefix used in HMACSHAStrategy configurable #789

Closed
3 of 5 tasks
mitar opened this issue Jan 29, 2024 · 2 comments
Closed
3 of 5 tasks

Make prefix used in HMACSHAStrategy configurable #789

mitar opened this issue Jan 29, 2024 · 2 comments
Labels
feat New feature or request.

Comments

@mitar
Copy link
Contributor

mitar commented Jan 29, 2024

Preflight checklist

Ory Network Project

No response

Describe your problem

I think this is primarily vanity, but HMACSHAStrategy used hard-coded ory_ prefix and I would prefer to have it be something branded for my own project.

Describe your ideal solution

I think just additional config option to configure the prefix would work well.

Workarounds or alternatives

Copying the HMACSHAStrategy and changing that small string. I think this is done in authelia.

Version

latest master

Additional Context

No response

@mitar mitar added the feat New feature or request. label Jan 29, 2024
@mitar
Copy link
Contributor Author

mitar commented Sep 15, 2024

I think this has been done with #816. (It is not customizable, but at least it is easy to wrap it yourself with prefix you want.)

@aeneasr
Copy link
Member

aeneasr commented Sep 16, 2024

I agree, while it's still not possible out of the box, it's now easier to do this with the copy strategy.

@aeneasr aeneasr closed this as completed Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request.
Projects
None yet
Development

No branches or pull requests

2 participants