diff --git a/.github/workflows/cve-scan.yaml b/.github/workflows/cve-scan.yaml index 20243850..455da42c 100644 --- a/.github/workflows/cve-scan.yaml +++ b/.github/workflows/cve-scan.yaml @@ -32,7 +32,7 @@ jobs: severity-cutoff: critical add-cpes-if-none: true - name: Inspect action SARIF report - run: cat ${{ steps.scan.outputs.sarif }} + run: cat ${{ steps.scan.outputs.sarif }} - name: Upload SARIF report uses: github/codeql-action/upload-sarif@v2 with: @@ -45,4 +45,4 @@ jobs: output-format: table fail-build: true severity-cutoff: critical - add-cpes-if-none: true \ No newline at end of file + add-cpes-if-none: true diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 111e88b4..17f40eba 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -143,10 +143,12 @@ checklist to contribute an example: not get mixed up. 1. Add a descriptive prefix to commits. This ensures a uniform commit history and helps structure the changelog. Please refer to this - [list of prefixes for CLI](https://github.com/ory/cli/blob/master/.github/semantic.yml) - for an overview. + [Convential Commits configuration](https://github.com/ory/cli/blob/master/.github/workflows/conventional_commits.yml) + for the list of accepted prefixes. You can read more about the Conventional + Commit specification + [at their site](https://www.conventionalcommits.org/en/v1.0.0/). 1. Create a `README.md` that explains how to use the example. (Use - [the README template](https://github.com/ory/examples/blob/master/_common/README)). + [the README template](https://github.com/ory/examples/blob/master/_common/README.md)). 1. Open a pull request and maintainers will review and merge your example. ## Contribute code @@ -171,8 +173,10 @@ request, go through this checklist: 1. Run `make format` 1. Add a descriptive prefix to commits. This ensures a uniform commit history and helps structure the changelog. Please refer to this - [list of prefixes for CLI](https://github.com/ory/cli/blob/master/.github/semantic.yml) - for an overview. + [Convential Commits configuration](https://github.com/ory/cli/blob/master/.github/workflows/conventional_commits.yml) + for the list of accepted prefixes. You can read more about the Conventional + Commit specification + [at their site](https://www.conventionalcommits.org/en/v1.0.0/). If a pull request is not ready to be reviewed yet [it should be marked as a "Draft"](https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request).