-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect git replace
#826
Comments
Thanks for opening your first issue at git-cliff! Be sure to follow the issue template! ⛰️ |
Hello, thanks for reporting!
Maybe @alerque knows something about this, since I think he's more of a Git guru than I am. |
Using I expect that libgit2 does support this already, but that one would have to explicitly query for it all the time since it is a side car along for the ride not the bike—it's a kind of filter-on-use rather than the actual history being changed. When you look at the |
amend changes the history, replace does not. I want to reword some commits on |
Yes, See commit_preprocessors = [
{ pattern = '.*', replace_command = 'typos --quiet --write-changes -' },
] There are also mechanisms including a JSON dump you can process yourself. |
Reported to Meanwhile this reminds me of #131 which should happen sometime. |
Upstream libgit2 issue has been open for 11 years‽ Yah it might be time to give gitoxide a shake. |
FWIW, how sensible would it be do to manual parsing of the files in |
That might be a bit of work that is outside of git-cliff's scope. It would probably be better to offload it to another library and bring it to git-cliff that way. Can't say something certain without seeing the implementation though. |
Somewhere north of "crazy pants" but not all the way to "maniac yolo on meth". Just don't. Even if the actual format is pretty stable unless you are in the business of monkeying with Git internals there are too many things that can go sideways. Starting (but by no means ending) with that stuff may or may not be in a |
According to the docs,
however I have no idea how to verify it, |
Is there an existing issue for this?
Description of the bug
When editing a commit message with
git replace --edit <commit-sha1>
,git cliff
keeps displaying the message of the old commit. It should instead display the message of the new commit that replaced the old one. More info aboutgit replace
Steps To Reproduce
Expected behavior
Changelog
All notable changes to this project will be documented in this file.
[unreleased]
Miscellaneous Tasks
Screenshots / Logs
No response
Software information
Additional context
No response
The text was updated successfully, but these errors were encountered: