Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling topological order for commits #804

Open
1 task done
orhun opened this issue Aug 20, 2024 · 5 comments
Open
1 task done

Allow disabling topological order for commits #804

orhun opened this issue Aug 20, 2024 · 5 comments
Labels
feature/request New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@orhun
Copy link
Owner

orhun commented Aug 20, 2024

Is there an existing issue or pull request for this?

  • I have searched the existing issues and pull requests

Feature description

See #800 for the problem description. To put it briefly, there might be edge cases where the changelog commits aren't ordered correctly when the merge commits are used.

Desired solution

Topological order was introduced as default behavior in #415. This behavior should be configurable (e.g. as date order) in the configuration file as follows:

# sort the commits topologically
topo_order_commits = false

We can also rename topo_order option to topo_order_tags for better alignment between these two options.

I'm not the best at naming. Maybe @Cyclonit have better ideas since he worked on #541

Alternatives considered

None.

Additional context

See #800

@orhun orhun added the feature/request New feature or request label Aug 20, 2024
@orhun orhun self-assigned this Aug 20, 2024
@orhun orhun removed their assignment Sep 21, 2024
@orhun orhun added help wanted Extra attention is needed good first issue Good for newcomers labels Sep 21, 2024
@orhun
Copy link
Owner Author

orhun commented Sep 21, 2024

This will probably fix #498 and #585

@alerque
Copy link
Contributor

alerque commented Oct 21, 2024

I'm guessing this is the issue I'm having with decasify whereby if I regenerate the changelog it nukes any record of the v0.6.0 release from orbit and stuffs the only related commit (from a long running breaking change branch) into the v0.5.8 changelog where it does not belong.

@orhun
Copy link
Owner Author

orhun commented Oct 29, 2024

Yeah... It's not super ideal but we should turn my suggestion solution into reality for the next release.

@lxb1226
Copy link

lxb1226 commented Nov 25, 2024

Is anyone work for this, may be i can try it?

@orhun
Copy link
Owner Author

orhun commented Dec 4, 2024

Please go ahead @lxb1226 if you are still interested!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/request New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants