-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(crates): change to workspace with separate crates #66
Conversation
msrv does not support workspace inheritance. Added a workaround, that needs to be updated for each crate. |
Not sure why tests are failing. They work locally... Edit: Found out why. When OUT_DIR is not set the tests skip without error. Changed it to use target dir by default. |
55b1070
to
2500e2a
Compare
Codecov ReportAttention: ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
📢 Thoughts on this report? Let us know!. |
Sorry, busy days, will try to review this soon. |
No worries, same for me. Take your time :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some initial comments!
With a quick check I realized the tracing logs do not appear when I do I think we need to update the directive in the |
Fixed it. Problem was, that it was using My first approach was to provide different log levels using the verbose flag, which was not the cause of the problem. Decided to keep it in, as it is an improvement over the old version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (I pushed some commits for polishing - move fast and break things ™️)
FYI
|
Description of change
Refactored code into separate crates in a workspace as preparation for #54
Note: I needed to do a few code changes to get proper separation. Ill add comments to those.
How has this been tested? (if applicable)