Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit permissions of service user and update docs for security #49

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Limit permissions of service user and update docs for security #49

wants to merge 1 commit into from

Conversation

bdhoine
Copy link
Collaborator

@bdhoine bdhoine commented Sep 28, 2023

No description provided.

@bdhoine bdhoine requested a review from royteeuwen September 28, 2023 21:34
@bdhoine bdhoine self-assigned this Sep 28, 2023
@bdhoine bdhoine linked an issue Sep 28, 2023 that may be closed by this pull request
Improve documentation of binding variables and methods #46
Open
@bdhoine bdhoine force-pushed the 46-improve-documentation-of-binding-variables-and-methods branch from 359d590 to baad69a Compare September 28, 2023 21:36
@royteeuwen royteeuwen mentioned this pull request Sep 29, 2023
Open
subiron
subiron reviewed Sep 29, 2023
View reviewed changes
CHANGELOG.md Outdated
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Permissions for service user are only to save scripts, replicate scripts and read user groups [#46](https://github.com/orbinson/aem-groovy-console/issues/46)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imho it should be market as 'breaking changes'

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was the plan

@bdhoine bdhoine force-pushed the 46-improve-documentation-of-binding-variables-and-methods branch 2 times, most recently from 49368a5 to 76e8f14 Compare October 1, 2023 18:40
@bdhoine bdhoine force-pushed the 46-improve-documentation-of-binding-variables-and-methods branch from 76e8f14 to 5bdaabe Compare October 1, 2023 18:42
@sonarcloud
Copy link

sonarcloud bot commented Oct 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@royteeuwen
Copy link
Contributor

@bdhoine are you going to still implement this one, or should this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subiron subiron subiron left review comments

@royteeuwen royteeuwen royteeuwen approved these changes

Assignees

@bdhoine bdhoine

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve documentation of binding variables and methods
3 participants
@bdhoine @royteeuwen @subiron