Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add playsinline to videoJS for proper operation on apple #368

Closed
benoit74 opened this issue Oct 15, 2024 · 5 comments · Fixed by #374
Closed

Add playsinline to videoJS for proper operation on apple #368

benoit74 opened this issue Oct 15, 2024 · 5 comments · Fixed by #374
Assignees
Labels
Milestone

Comments

@benoit74
Copy link
Collaborator

Since we want the video to play inline by default, we have to set the playsinline attribute on video tag.

@benoit74 benoit74 added the bug label Oct 15, 2024
@benoit74 benoit74 added this to the 3.2.1 milestone Oct 15, 2024
@guptushar27
Copy link

hi i can debug this

@benoit74
Copy link
Collaborator Author

There is nothing to debug, just work to do. Do you wanna propose a PR? I've assigned the issue, please propose a PR quickly (by the end of the week at most) or I'll probably work on it, it is just a very tiny change and we would like to release it soon.

@guptushar27
Copy link

I will do this by sunday morning

@kelson42
Copy link
Contributor

@benoit74 Can we found please a way to ensure that if we have an issue around video.js, it is always fixed everywhare. I'm really surprise to see this bug, as I though it was already fixed everywhere. See openzim/python-scraperlib#194

@benoit74
Copy link
Collaborator Author

See my last answers in openzim/python-scraperlib#194 ; you keep complaining, we keep explaining it is a problem of tooling / procedures, not something easy to fix. And it will never be fixed everywhere quickly, at least not with our current funding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants