Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New UI: Finish removal of locale for now #226

Closed
benoit74 opened this issue Jun 14, 2024 · 0 comments · Fixed by #232
Closed

New UI: Finish removal of locale for now #226

benoit74 opened this issue Jun 14, 2024 · 0 comments · Fixed by #232
Assignees
@dan-niles
Labels
task
Milestone
3.0.0

Comments

@benoit74
Copy link
Collaborator

In #212 we removed the "locale" thing since it was anyway broken.

We however forgot to remove the call the setlocale in scraper.py, which breaks the scraper since locale isn't available.

This should be cleaned-up as well until we decide how to implement translations in new UI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dan-niles dan-niles

Labels
task
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Finish removal of locale related code openzim/youtube
2 participants
@benoit74 @dan-niles