Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining code qa and typing issues resulting in breaking changes #131

Closed
benoit74 opened this issue Feb 12, 2024 · 2 comments · Fixed by #178
Closed

Fix remaining code qa and typing issues resulting in breaking changes #131

benoit74 opened this issue Feb 12, 2024 · 2 comments · Fixed by #178
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@benoit74
Copy link
Collaborator

#128 has shown that there is some code qa / typing issues that have to be fixed but will ultimately lead to a breaking change in term of API, hence needing a major release.

  • fix all FBT001 / FTB002
  • fix N813, N818
  • rename getLogger to get_logger
  • decide about N803 issues in config_metadata of zim/creator.py (this has been made intentionally to match the real tag name)
  • fix many typing issues:
    • the ones associated with RUF013
    • the ones around metadata validation
    • other issues should be investigated as well
@benoit74 benoit74 added the enhancement New feature or request label Feb 12, 2024
@benoit74 benoit74 added this to the 4.0.0 milestone Feb 12, 2024
@benoit74
Copy link
Collaborator Author

We should as well rename image/convertion.py to image/conversion.py

@benoit74
Copy link
Collaborator Author

Fix reencode return type to be consistent + add type hints (code is ready in fix_reencode_return_types branch but it is a breaking change in term of API).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant