Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI builds with node 16.x Fatal Error #1758

Closed
uriesk opened this issue Jan 27, 2023 · 4 comments · Fixed by #1769
Closed

CI builds with node 16.x Fatal Error #1758

uriesk opened this issue Jan 27, 2023 · 4 comments · Fixed by #1769
Assignees
Labels
Milestone

Comments

@uriesk
Copy link
Collaborator

uriesk commented Jan 27, 2023

About 2 out of 3 CI builds fail with

#
# Fatal error in , line 0
# Check failed: result.second.
#
#
#
#FailureMessage Object: 0x7ffc28eee030
 1: 0xb71fa1  [node]
 2: 0x1bf9fa4 V8_Fatal(char const*, ...) [node]
 3: 0xfb7601 v8::internal::GlobalBackingStoreRegistry::Register(std::shared_ptr<v8::internal::BackingStore>) [node]
 4: 0xd08ff8 v8::ArrayBuffer::GetBackingStore() [node]
 5: 0xae[27](https://github.com/openzim/mwoffliner/actions/runs/4026998437/jobs/6922197530#step:12:28)41  [node]
 6: 0xd3ddfe  [node]
 7: 0xd3f21f v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [node]
 8: 0x15d9cf9  [node]
Illegal instruction (core dumped)

You can re-run it till it eventually succeeds. But it is getting annoying now.

Looking at the error, i find reports for node nodejs/node#32463 and node-addon-api nodejs/node-addon-api#799
Here some other project solves it by switching from ArrayBuffer to Externals eilvelia/tdl#119

We could either test different node 16.x versions till we find one that is more stable, or we drag it over to openzim/node-libzim, cause that is probably what triggers it.

@kelson42 kelson42 added the bug label Jan 27, 2023
@kelson42 kelson42 added this to the 1.12.0 milestone Jan 27, 2023
@kelson42
Copy link
Collaborator

Seems to be a regression to me as we don't have changed anythin at node-libzim since many months.

@uriesk
Copy link
Collaborator Author

uriesk commented Jan 29, 2023

We won't be able to solve this.
We would have to wait for some node 16.x or other update that fixes it.
But until then, node 16 reached end-of-life (september this year), while 18 is the current LTS.

I rather drop node 16 support and add node 19 (so we got current release and current LTS) than waste time with this.

@kelson42
Copy link
Collaborator

@uriesk Not super happy to drop support of Node.js 16.x... but if there is a really good reason. OK for me. AFAIK we can not automated test so far for Node.js 19, last time I tried, somehow the action which should install it was not ready.

To conclude: OK for me to drop Node.js 16 (we should take care the doc, and necessary check of Node version should be implemented/updated). At the end Node.js 18 is still pretty recent.

@uriesk
Copy link
Collaborator Author

uriesk commented Jan 29, 2023

Lets think about that in 1.13 then.
This bug is just an annoyance and not urgent.

@kelson42 kelson42 modified the milestones: 1.12.0, 1.13.0 Jan 29, 2023
@kelson42 kelson42 self-assigned this Feb 5, 2023
@kelson42 kelson42 modified the milestones: 1.13.0, 1.12.1 Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants