Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Measure Now and Run Tab display measure html output differently #411

Open
macumber opened this issue Aug 7, 2021 · 3 comments
Open

Comments

@macumber
Copy link
Collaborator

macumber commented Aug 7, 2021

Issue overview

Measure html output written to register info should be rendered the same in both Apply Measure Now and the Run Tab. Currently there are two different implementations that render differently.

errorsStyle = "QLabel { color : red; }";

and

auto appendErrorText = [&](const QString& text) {
m_textInfo->setTextColor(Qt::red);
m_textInfo->setFontPointSize(18);
m_textInfo->append(text);
};

We should have a shared implementation for these two tabs

@macumber macumber added the Triage Issue needs to be assessed and labeled, further information on reported might be needed label Aug 7, 2021
@macumber
Copy link
Collaborator Author

macumber commented Aug 7, 2021

Example measure: measure.rb.txt

@macumber macumber added component - UI severity - Normal Bug 🐛 and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Aug 7, 2021
@macumber
Copy link
Collaborator Author

macumber commented Aug 7, 2021

Might also consider making both UIs use a fixed width font so measure writers can control formatting.

const QFont fixedFont = QFontDatabase::systemFont(QFontDatabase::FixedFont)

@jmarrec
Copy link
Collaborator

jmarrec commented May 2, 2022

This is going to be very annoying to do. The RunTabView is one big QTextEdit currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants