-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add translatable strings to social_facility:for field #934
Conversation
Approved values only
🍱 Preview the tagging presets of this pull request here: https://pr-934--ideditor-presets-preview.netlify.app/id/dist/#locale=en. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd use the plural form for the values and be a bit more specific in some cases. See inline suggestions below.
Also, could you please add the missing values from the list in the wiki, i.e. dementia
, displaced
, terminally_ill
, unemployed
, veteran
and woman
. Yes, these are relatively rare, but in my opinion they do make sense to be offered.
//edit: PS:
Approved values only
In this case, I would go with the list on the wiki page, as the tag has clearly evolved slightly after the proposal phase. E.g. the value under_privileged
is now practically unused compared to underprivileged
.
Co-authored-by: Martin Raifer <[email protected]>
Co-authored-by: Martin Raifer <[email protected]>
Co-authored-by: Martin Raifer <[email protected]>
Co-authored-by: Martin Raifer <[email protected]>
Co-authored-by: Martin Raifer <[email protected]>
Co-authored-by: Martin Raifer <[email protected]>
Co-authored-by: Martin Raifer <[email protected]>
Co-authored-by: Martin Raifer <[email protected]>
Co-authored-by: Martin Raifer <[email protected]>
Co-authored-by: Martin Raifer <[email protected]>
Co-authored-by: Martin Raifer <[email protected]>
Approved values only