-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translatable strings for payment types #255
Conversation
"ep_easycard": "悠遊卡EasyCard", | ||
"ep_geldkarte": "GeldKarte", | ||
"ep_ipass": "iPASS一卡通", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strings for Taiwan’s ep_easycard
and ep_ipass
systems include the official Chinese name to avoid confusion with the Easy Card and I-PASS systems in the United States.
"apple_pay": "Apple Pay", | ||
"bancomat": "Bancomat", | ||
"blik": "Blik", | ||
"clipper": "Clipper", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These labels may seem trivial, but they’re properly capitalized to make the raw key look more presentable, and some of these brands have different official names in other languages or scripts.
Is that really how multiCombo works? It combines values from taginfo with the explicitly defined values? |
It’s how the So far, no |
I was using the built-ins when available, or tagInfo if not, but didn't think to union them. Thanks! |
9d3204d
to
49f529e
Compare
Added human-readable, translatable strings for the most common payment types that are documented on the
payment
key’s wiki page. There are a great manypayment:*
subkeys, including plenty that are valid but undocumented, but this PR doesn’t attempt to enumerate them all. The subkeys omitted from this PR will continue to appear in the menu but as a raw value rather than a pretty-printed one.I included most subkeys used at least 1,000 times according to taginfo. However, I omitted the following subkeys based on guidance on the wiki:
none
is discouraged because setting it toyes
ambiguously means free of charge (fee=no
) or cannot be purchased.others
has to be set tono
, but themultiCombo
field type only allows subkeys to be taggedyes
.bitcoin
andbitcoincash
are discouraged in favor of thecurrency:XBT
andcurrency:BCH
keys, respectively.mobile_phone
is ambiguous; it variously meansphone
,sms
, orapp
.It remains possible to tag these subkeys, since the
multiCombo
field is freeform, but the field wouldn’t encourage the use of these subkeys.